Skip to content

[WIP] L2CAP Enhanced Retransmission mode #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[WIP] L2CAP Enhanced Retransmission mode #779

wants to merge 2 commits into from

Conversation

@zxzxwu
Copy link
Collaborator

@zxzxwu zxzxwu commented Sep 17, 2025 •
edited
Loading

Ported from Pigweed without actual retransmission support, because most devices don't perform retransmission at all.

@zxzxwu zxzxwu marked this pull request as draft September 17, 2025 05:45
@zxzxwu zxzxwu force-pushed the l2cap branch 2 times, most recently from 8187bea to 76f636a Compare September 19, 2025 06:01
@zxzxwu zxzxwu force-pushed the l2cap branch 8 times, most recently from 44955d1 to 9cfa0a3 Compare September 26, 2025 17:17
@zxzxwu
Copy link
Collaborator Author

zxzxwu commented Sep 26, 2025

@barbibulle This PR is still WIP, but I would like to have your opinion about the overall design.

@zxzxwu zxzxwu requested a review from barbibulle September 30, 2025 07:24
@barbibulle
Copy link
Collaborator

barbibulle commented Nov 2, 2025

@barbibulle This PR is still WIP, but I would like to have your opinion about the overall design.

I'll take a look in the next couple days.

@zxzxwu
Copy link
Collaborator Author

zxzxwu commented Nov 2, 2025

Thanks!

Some summary:

  • Retransmission is not implemented. I am considering introduce an Busy exception allow packet receivers to raise REJ or SREJ, but probably will be another PR.
  • Config negotiation is WIP. I am still figuring out how it works.
  • Using processor classes to handle mode-specific logics. A potential improvement is to allow delegating factory for each mode.
  • Add write() and on_sdu() to allow sending SDU in non-basic modes, but keep the behavior in basic mode.
  • Add FCS support - though this is optional in Enhanced Retransmission mode, many implementations don't allow such combination.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@barbibulle barbibulle Awaiting requested review from barbibulle

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zxzxwu @barbibulle